-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP (Help needed): Add switch to only download with wifi connection. #336
Conversation
@jmshrv could you help here? |
Just pushed the stuff to save the setting in FinampSettings, you can access the value with |
@jmshrv hey thank you thats great 🥳 |
Hi, sorry for the delay, I'm working through my pile of emails right now :)
We'll need to jump to a new version of flutter_downloader, it's been pinned on my own branch of it for a while. Shouldn't cause any issues, the fix in my branch has been merged into a release. |
@Y0ngg4n do you want to try and update |
@Chaphasilor currently i don´t have the capacities for it sorry :( |
This will probably be superseded by #568, but I can still try to get this merged before the next version is released :) |
Na i think we can close this then if it is going to be superseded. |
I mean the other PR targets I'll see if I have the time to fix the merge conflicts... Oh and Merry Christmas! 🎄 |
Ok i understand 🤔 would be nice. But this MR wasnt working either. And Merry Christmas to you too :) |
@Y0ngg4n could you tell me what wasn't working? I'm not sure I have the capacity to fix it up, but if it's only a small-ish issue I might do it. |
@Chaphasilor close it :) |
This adds a basic switch to the settings menu to only download music with wifi connection. But i need help with this to save to hive db and register the notifier with provider. Dont want to destroy the current models.